Prepare nbs to ydb#1784 #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3b2623 to
a7d5f1a
Compare
|
It's temporary on hold. Seem's that ymake don't understand conditional includes, so I have to think about different approach |
a7d5f1a to
547ca2f
Compare
|
Okay, I found workaround for this -- we will just ignore it with |
|
@qkrorlqr Could we discuss this change? It is blocking us |
I don't see any results indicating that this activity improves something (build time?). Here ydb-platform/ydb#1784 I see lots of failed tests and builds in most of those PR-checks - I don't understand, how can we draw conclusions from such unstable measurements. |
547ca2f to
9290f36
Compare
qkrorlqr
approved these changes
Feb 26, 2024
1ec106c to
ab37dc1
Compare
EvgeniyKozev
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to disable PROTOC_TRANSITIVE_HEADERS in
ydb/core/protosin ydb-platform/ydb#1784 to make this transition smooth for you I added additional include which brings back old behavior.In case you want to speed up your builds as well you can remove this include and replace it with includes really needed.