CsCompleter: Implement GoToDocumentOutline.

[teasp00n]

Implements GoToDocumentOutline in the CsCompleter to support YCMFindSymbolInDocument functionality for cs projects.

---

This change is 

[bstaletic]

Thanks for the pull request!
Would you mind taking a look at subcommands_test.py and adding a test (or two, another for the error case)?
If you need assistence, feel free to hop over to our gitter channel.

Reviewable status: 0 of 2 LGTMs obtained

[bstaletic]

Reviewable status: 0 of 2 LGTMs obtained (waiting on @teasp00n)

---

ycmd/completers/cs/cs_completer.py line 686 at r1 (raw file):

      return goto_locations
    else:
      raise RuntimeError( 'No symbols found' )

I can't seem to find the definition of QuickFix, but does this cover the case of zero identifiers in a file, or just things like "file not found"?

[bstaletic]

Reviewed 3 of 4 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @teasp00n)

---

ycmd/completers/cs/cs_completer.py line 686 at r1 (raw file):

Previously, bstaletic (Boris Staletic) wrote…

I can't seem to find the definition of QuickFix, but does this cover the case of zero identifiers in a file, or just things like "file not found"?

We normally do throw an exception when an error occurs, or the response is empty.
Something like raise RuntimeError('No definitions found.'), because thetn the clients know to display that error to users, instead of just silently doing nothing.

We could debate whether exceptions are the right way to handle this, but after 10 years, this is pretty firmly baked into ycmd's API.

To be precise:

• If we have 1+ refs in the response, we should return the list.
• Otherwise we should throw.

[puremourning]

Thanks so much!

Reviewed 2 of 4 files at r3, 2 of 2 files at r5, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @teasp00n)

[puremourning]

can we squash the commits?

Reviewable status: 0 of 2 LGTMs obtained (and 1 stale) (waiting on @teasp00n)

[puremourning]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (and 1 stale) (waiting on @teasp00n)

[codecov]

Codecov Report

Merging #1723 (3a07ac6) into master (9e43034) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1723   +/-   ##
=======================================
  Coverage   95.46%   95.47%           
=======================================
  Files          83       83           
  Lines        8162     8175   +13     
  Branches      163      163           
=======================================
+ Hits         7792     7805   +13     
  Misses        320      320           
  Partials       50       50           

[puremourning]

Reviewed all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (and 1 stale) (waiting on @teasp00n)

[puremourning]

Reviewable status: 1 of 2 LGTMs obtained (waiting on @teasp00n)

[puremourning]

Reviewable status: 1 of 2 LGTMs obtained (waiting on @teasp00n)

[puremourning]

Reviewable status: 1 of 2 LGTMs obtained (waiting on @teasp00n)

implemented in recent changes.

[puremourning]

Dismissed @bstaletic from a discussion.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @teasp00n)

[mergify]

Thanks for sending a PR!