[READY] Update jdt.ls to 0.25.0 #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
==========================================
- Coverage 97.58% 97.56% -0.02%
==========================================
Files 89 89
Lines 6992 6994 +2
==========================================
+ Hits 6823 6824 +1
- Misses 169 170 +1 |
aa1c7b7 to
80eb81d
Compare
micbou
commented
Sep 28, 2018
There was a problem hiding this comment.
The Subcommands_RefactorRename_MultipleFiles test is now expected to fail.
Reviewed 5 of 5 files at r1.
Reviewable status: 0 of 2 LGTMs obtained
The hover response does not return a list with only one item anymore but instead return the item directly. An empty list of diagnostics is returned for the project root. Renaming only works for valid identifiers. A regression has been introduced: renaming a method does not rename places where the method is overridden. Catch PollForMessagesTimeoutException from thread in Poll_Diagnostics_ProjectWide_Eclipse_test test.
80eb81d to
57a1691
Compare
bstaletic
approved these changes
Sep 30, 2018
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: 0 of 2 LGTMs obtained (and 1 stale)
micbou
commented
Sep 30, 2018
There was a problem hiding this comment.
Thanks for the review. I am triggering zzbot since it's blocking PR #1113.
Reviewable status: 1 of 2 LGTMs obtained
|
@zzbot r+ |
|
📌 Commit 57a1691 has been approved by |
zzbot
added a commit
that referenced
this pull request
Sep 30, 2018
[READY] Update jdt.ls to 0.25.0
Some changes were required:
- the hover response does not return a list with only one item anymore but instead return the item directly e.g. `{ 'language': 'java', 'value': 'some value' }` is returned instead of `[ { 'language': 'java', 'value': 'some value' } ]`;
- for some reason, an empty list of diagnostics is returned for the project root;
- renaming only works for valid identifiers (`a-quite-long-string` is not a valid Java identifier);
- a regression has been introduced: renaming a method does not rename places where the method is overridden. See eclipse-jdtls/eclipse.jdt.ls#802.
The `PollForMessagesTimeoutException` exception from `Poll_Diagnostics_ProjectWide_Eclipse_test` is suppressed.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1109)
<!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
zzbot
added a commit
that referenced
this pull request
Oct 1, 2018
Add necessary client capability support for new completion item kinds Implemented necessary capability support for new completion item kinds as mentioned in the [Initialize Params/ClientCapabilities/TextDocumentClientCapabilities/completionItemKind](https://microsoft.github.io/language-server-protocol/specification#initialize) ```typescript /** * The completion item kind values the client supports. When this * property exists the client also guarantees that it will * handle values outside its set gracefully and falls back * to a default value when unknown. * * If this property is not present the client only supports * the completion items kinds from `Text` to `Reference` as defined in * the initial version of the protocol. */ ``` After the change java tests were getting stuck and timing out. Updating version of jdt.ls resolves that issue but found out that there were some regressions as mentioned in #1109. So need to wait until it is merged. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1113) <!-- Reviewable:end -->
zzbot
added a commit
that referenced
this pull request
Oct 1, 2018
Add necessary client capability support for new completion item kinds Implemented necessary capability support for new completion item kinds as mentioned in the [Initialize Params/ClientCapabilities/TextDocumentClientCapabilities/completionItemKind](https://microsoft.github.io/language-server-protocol/specification#initialize) ```typescript /** * The completion item kind values the client supports. When this * property exists the client also guarantees that it will * handle values outside its set gracefully and falls back * to a default value when unknown. * * If this property is not present the client only supports * the completion items kinds from `Text` to `Reference` as defined in * the initial version of the protocol. */ ``` After the change java tests were getting stuck and timing out. Updating version of jdt.ls resolves that issue but found out that there were some regressions as mentioned in #1109. So need to wait until it is merged. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1113) <!-- Reviewable:end -->
zzbot
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
Oct 7, 2018
[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#1075: remove Node.js workaround for Debian-based distributions; - PR ycm-core/ycmd#1077: update Boost to 1.68; - PR ycm-core/ycmd#1078: add semantic trigger for Julia; - PR ycm-core/ycmd#1081: improve type information on C++ member functions; - PR ycm-core/ycmd#1086: check if Python headers are installed before building; - PR ycm-core/ycmd#1088: raise proper exception for commands when file is still being parsed in C-family languages; - PR ycm-core/ycmd#1098: update Go completer; - PR ycm-core/ycmd#1099: update regex submodule; - PR ycm-core/ycmd#1100: add Python path to debugging information; - PR ycm-core/ycmd#1103: support framework headers completion and code navigation in C-family languages; - PR ycm-core/ycmd#1107: update Clang to 7.0.0; - PR ycm-core/ycmd#1109: update jdt.ls to 0.25.0; - PR ycm-core/ycmd#1110: handle null hover response from language servers; - PR ycm-core/ycmd#1111: update list of completion kinds defined by LSP; - PR ycm-core/ycmd#1113: send completion item kinds capability to language servers; - PR ycm-core/ycmd#1116: update Parso to 0.3.1 and Jedi to 0.13.1. Closes #3138. Closes #3145. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3175) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes were required:
{ 'language': 'java', 'value': 'some value' }is returned instead of[ { 'language': 'java', 'value': 'some value' } ];a-quite-long-stringis not a valid Java identifier);The
PollForMessagesTimeoutExceptionexception fromPoll_Diagnostics_ProjectWide_Eclipse_testis suppressed.This change is