Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with progress bar #526

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Fix issues with progress bar #526

merged 1 commit into from
Oct 6, 2016

Conversation

Daniel15
Copy link
Member

@Daniel15 Daniel15 commented Oct 6, 2016

Tweaks to progress bar:

  • Decrease width by 1 to account for the fact that some terminals take an extra character for the cursor. Cmder and cmd.exe definitely do, I think a few terminal emulators on Linux do too.
  • When re-rendering, just go to the start of the line rather than clearing the line. This prevents flicker by rendering directly on top of the previous state, rather than totally clearing the line before rendering again. (I didn't notice any flicker in Cmder, I did notice it in cmd.exe though)

This fixes the issues on Windows.

Before:
05-22 21 01

After:
05-22 19 37

Confirmed this works in Cmder, cmd.exe and PowerShell.

cc @cpojer @wycats

 - Decrease width by 1 to account for the fact that some terminals need an extra character for the cursor
 - When re-rendering, just go to the start of the line rather than clearing the line. This prevents flicker
@cpojer cpojer merged commit 49ba818 into yarnpkg:master Oct 6, 2016
@cpojer
Copy link
Contributor

cpojer commented Oct 6, 2016

I rebased this locally. Git seems to have some major issues with line endings in tar files for some odd reasons.

@cpojer
Copy link
Contributor

cpojer commented Oct 6, 2016

Thank you @Daniel15!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants