Fix: Add $NODE when running scripts and make yarn env reflect these
#4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Fixes #2609. This patch adds a `$NODE` environment variable when running scripts through `yarn run` which is set to `process.execPath` unless it is formerly set to something else. `$npm_node_execpath` is now just an alias to `$NODE`. The patch also updates `yarn env` to show these extra environment variables. **Test plan** Updates existing `yarn env` tests.
arcanis
reviewed
Aug 25, 2017
src/util/execute-lifecycle-script.js
Outdated
|
|
||
| // Merge in the `env` object specified in .yarnrc | ||
| const customEnv = config.getOption('env'); | ||
| if (customEnv && typeof customEnv === 'object') { | ||
| Object.assign(env, customEnv); | ||
| } | ||
|
|
||
| if (!env.NODE) { | ||
| env.NODE = process.execPath; | ||
| } |
There was a problem hiding this comment.
Won't that cause problem in the following case?:
$> export NODE=node-4.0
$> node-8.0 yarn.js run ...
In this case, yarn will run will node 8, but its scripts will use node 4. Is it expected?
arcanis
approved these changes
Aug 25, 2017
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
…se (yarnpkg#4260) **Summary** Fixes yarnpkg#2609. This patch adds a `$NODE` environment variable when running scripts through `yarn run` which is set to `process.execPath` unless it is formerly set to something else. `$npm_node_execpath` is now just an alias to `$NODE`. The patch also updates `yarn env` to show these extra environment variables. **Test plan** Updates existing `yarn env` tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2609. This patch adds a
$NODEenvironment variable when runningscripts through
yarn runwhich is set toprocess.execPathunless itis formerly set to something else.
$npm_node_execpathis now just analias to
$NODE.The patch also updates
yarn envto show these extra environmentvariables.
Test plan
Updates existing
yarn envtests.