-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a failing test for version conflicts #3779
Conversation
0238a05
to
f1de0ed
Compare
{ | ||
"version": "0.0.1", | ||
"dependencies": { | ||
"left-pad": ">=0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean 1.0.1?
Don't think so I think >=0.0.1 and 1.0.0 should not conflict? This test shows that they do conflict. (looks like >=0.0.1 resolves to a hard pin for whatever the latest version is?) This behaviour was not present prior to 0.27.0 |
f1de0ed
to
6476dc5
Compare
@bestander Skipped the test, added comment linking to issue. I'll have a go at #3778 :) |
Awesome!
…On Sun, Jul 2, 2017 at 10:19 AM Mark Larah ***@***.***> wrote:
@bestander <https://github.com/bestander> Skipped the test, added comment
linking to issue.
I'll have a go at #3778 <#3778> :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3779 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACBdWO0zurtbtqml4vzAVkbRQeojzVHMks5sJ9E3gaJpZM4OLEIW>
.
|
Merged this, ping me on a fix :) |
…el dependency (#4488) **Summary** Fixes #3780, and makes the failing test from #3779 passing. As a final step of package resolution, for each dependency we check whether any version satisfies all resolved version ranges. **Test plan** Fixes an existing (failing) test: "unbound transitive dependencies should not conflict with top level dependency"
…el dependency (yarnpkg#4488) **Summary** Fixes yarnpkg#3780, and makes the failing test from yarnpkg#3779 passing. As a final step of package resolution, for each dependency we check whether any version satisfies all resolved version ranges. **Test plan** Fixes an existing (failing) test: "unbound transitive dependencies should not conflict with top level dependency"
Summary
This is a failing test to highlight the issue the issue here #3780 https://github.com/mxmul/yarn_flat_regression
tl;dr:
yarn fails when doing
--flat
with the following:(yarn version: 0.27.1)
(this seems to be a regression introduced in 0.27.0, this worked in 0.26.1)
Test plan
This is a test only change.
This test is currently failing because it's prompting for a resolution, with the following stacktrace