Allow git+***:// dependencies
#3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice work, @Volune! |
BYK
reviewed
Jun 29, 2017
| @@ -12,8 +12,10 @@ import Git from '../../util/git.js'; | |||
|
|
|||
| const urlParse = require('url').parse; | |||
|
|
|||
| const GIT_PROTOCOL_PATTERN = /git\+.+:/; | |||
There was a problem hiding this comment.
Since we're using patterns now, do you think we can remove GIT_PROTOCOLS and special casing for https:// + ends with .git custom rules and bake them into the pattern in the future?
|
Great!! o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing #3677
Test plan
Adding some tests on
getExoticResolverto ensure the Git resolver is used forgit+file:///dependencies.Implementation notes
I moved
getExoticResolvertosrc/resolvers/index.js, I think it's more suitable thansrc/package-request.js, and more convenient to write the tests. I also refactored at little to make the returned type more specific.I made the Git resolver handle any protocol prefixed with
git+, not onlygit+file. That way, yarn will handle as many protocols as git itself does.