PATCH for using .yarnrc registry url instead of default https://regis… #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestander
reviewed
May 30, 2017
| @@ -55,7 +55,10 @@ export default class NpmRegistry extends Registry { | |||
|
|
|||
| request(pathname: string, opts?: RegistryRequestOptions = {}, packageName: ?string): Promise<*> { | |||
| const registry = this.getRegistry(packageName || pathname); | |||
| const requestUrl = url.resolve(registry, pathname); | |||
| const requestBaseUrl = url.resolve(registry, pathname); // does not work... | |||
bestander
reviewed
May 30, 2017
| @@ -55,7 +55,10 @@ export default class NpmRegistry extends Registry { | |||
|
|
|||
| request(pathname: string, opts?: RegistryRequestOptions = {}, packageName: ?string): Promise<*> { | |||
| const registry = this.getRegistry(packageName || pathname); | |||
| const requestUrl = url.resolve(registry, pathname); | |||
| const requestBaseUrl = url.resolve(registry, pathname); // does not work... | |||
| const requestUrl = requestBaseUrl.replace('https://registry.yarnpkg.com/', registry); | |||
There was a problem hiding this comment.
I think you are on a right path.
Just make the domains configurable via .yarnrc.
Those can be read in config via getOption, e.g. https://github.com/yarnpkg/yarn/blob/master/src/config.js#L267
bestander
reviewed
May 30, 2017
| const requestUrl = url.resolve(registry, pathname); | ||
| const requestBaseUrl = url.resolve(registry, pathname); // does not work... | ||
| const requestUrl = requestBaseUrl.replace('https://registry.yarnpkg.com/', registry); | ||
| // console.log('PATCH npm-registry.request(' + pathname + '..) => requestUrl:' + requestUrl + ' instead of ' + requestBaseUrl); |
|
Thanks, @Arnaud-Nauwynck. |
|
ping, @Arnaud-Nauwynck |
|
I'll close as it can't be merge this way, please feel free to reopen after rebasing and addressing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…try.yarnpkg.com/
Summary
Test plan