Added support for more git URL formats #3445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After recent work on fixing the private shortened git URL formats I've noticed there are still some that do not work.
For example this URL format works:
But this format does not:
This work fixes this.
Test plan
Create a new directory with the following
package.json
:Without this fix you will get the following error:
(Notice the error:
Could not resolve hostname github
which is incorrect)With this fix you will able to install these modules as it will switch to ssh auth.