Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for more git URL formats #3445

Merged
merged 1 commit into from
May 19, 2017
Merged

Added support for more git URL formats #3445

merged 1 commit into from
May 19, 2017

Conversation

thedumbterminal
Copy link
Contributor

@thedumbterminal thedumbterminal commented May 17, 2017

Summary

After recent work on fixing the private shortened git URL formats I've noticed there are still some that do not work.

For example this URL format works:

github:thedumbterminal/test-private-node-module

But this format does not:

github:thedumbterminal/test-private-node-module.git

This work fixes this.

Test plan

Create a new directory with the following package.json:

{
  "name": "1",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
   "grunt-gemnasium": "github:thedumbterminal/grunt-gemnasium.git"
  }
}

Without this fix you will get the following error:

ssh: Could not resolve hostname github: nodename nor servname provided, or not known
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

(Notice the error: Could not resolve hostname github which is incorrect)

With this fix you will able to install these modules as it will switch to ssh auth.

@bestander bestander merged commit 77ce1c9 into yarnpkg:master May 19, 2017
@bestander
Copy link
Member

Thanks for adding tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants