check.js: Ignore dedup warnings for bundled dependencies

[rufman]

Any package with bundledDependencies will be added to a hash of bundled
deps, which are used to check against when printing dedup warnings.
This is because bundled dependencies could result in duplications which
we would otherwise detect as false positives.

Fixes #3299

Summary
yarn check shouldn't return dedup warnings for any bundled dependencies, such as in the case of nyc.

Test plan
A simple package.json with just nyc, will return 41 warnings for packages present in nyc's packageJson.bundledDependencies when doing yarn check on the current master. When doing yarn check on this commit, no warnings are returned, since the dedup warnings resulting from nyc's bundled dependencies are ignored.

[rufman]

I seem to have issues with continuous integration timing out on different tasks on every rebuild attempt. Is there a way to get the build to pass?

[bestander]

@rufman, thanks for the fix, looks great.
But could you come up with a more focused test?
nic produces a 1000 lines lockfile, test fixtures like that slow down tests runtime and make CI less stable.

Also you need to actually add code to the https://github.com/yarnpkg/yarn/blob/master/__tests__/commands/check.js that would execute the fixture and verify that warning is not printed.

[bestander]

Test needed

[rufman]

Ok, so I assume I would need to publish some test package that only has one dependency and one bundled dependency?

[bestander]

Probably no need to publish, you can commit a .tgz file in the test fixtures

…

On Sat, 13 May 2017 at 00:41, Stephane Rufer ***@***.***> wrote: Ok, so I assume I would need to publish some test package that only has one dependency and one bundled dependency. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3337 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBdWBO3akmQGbU8ureb84bzn6dUp8pwks5r5O4sgaJpZM4NSilM> .

[rufman]

@bestander I've rebased and added a test. The fixture now only contains one bundled dependency, so it should be much lighter.

[bcoe]

@rufman awesome work, thanks 👍