improvement behavior of files field in package.json #3166
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr make improve behavior of
files
inpackage.json
.According to npm docs,
files
field's priority is higher than some ignoring (ex:.npmignore
,.gitignore
) andfoo.js
will be treated as bothfoo.js
andfoo.js/**
.On example project like below
and
.gitignore
iswith
package.json
has{"files": ["dist"]}
Result of
npm pack
isBut
yarn pack
isBecause of that,
yarn publish
will publish package with emptydist
directory.Test plan