Do not test new version with pkg.version

[binarykitchen]

See issue 3011 for details. Leave it to npm registry to validate the version number.

Motivation is to make it work with the way how I deploy my videomail-client library at
https://github.com/binarykitchen/videomail-client/blob/develop/bin/release.sh

There I am already bumping to the new version in package.json before publishing it with yarn to npm.

Test plan

1. Manually increment version in a random package.json
2. Run yarn publish --new-version with that new version
3. Yarn won't complain anymore that the new version is the same.
4. It will be up to the npm registry whether to accept that version or not.

[voxsim]

hey @binarykitchen thanks for your pr, could you please write two tests for both cases instead of leaving a comment?

[binarykitchen]

not sure how this can be tested when it's up to the npm registry to validate version numbers ...

[binarykitchen]

@voxsim ok, have code to cover the first test case

but there are no tests at all for the yarn publish command, so cannot add the second test case. maybe make an empty file for now with todo comments and raise this as a separate issue?

[voxsim]

@binarykitchen maybe for now it is sufficient. Let @arcanis and @bestander decide if we need to do other stuff ;)

[arcanis]

Not sure this comment is needed.

However, shouldn't we just return early when the package version is the same as the version currently registered? Instead of running lifecycle hooks etc. Not doing this could cause issues if, for example, a version lifecycle script was registering a mercurial tag.

[binarykitchen]

true that @arcanis

... just have updated PR. now it's returning early and comment is much shorter

[arcanis]

👍 Would you mind also adding a --no-version option on the publish command to completely skip the version step?

[binarykitchen]

@arcanis i think that would raise scope and should got in a separate issue. my commit here only touches the version command. or am i missing something here?

[binarykitchen]

@arcanis ping?

[arcanis]

I'm ok with merging this! Just a nit: can you remove the comments? Such a small change is relatively self-explanatory, so no need to write in english what's already written in js :)

[binarykitchen]

@arcanis ok, all comments are removed - good now?

[bestander]

Great job, everyone!

[binarykitchen]

thanks - is there an eta when and in which version this will come out @bestander?

[bestander]

0.24 next week