Fix bug when cannot set a config value to empty string #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ! |
This was referenced Apr 28, 2017
|
This is still not working for me. I have yarn 1.3.2 installed. |
|
@coridrew What exactly is not working? Do you have steps to reproduce? For me it looks fine with yarn 1.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently
$ yarn config set <config_key> ""sets the respective config value to true. It should be possible to set config values to an empty string.Omitting config value should still default to true, e.g.
$ yarn config set strict-sslshould set strict-ssl config value to true.
Test plan
$ yarn config set version-tag-prefix ""should set version-tag-prefix config value to an empty string.