Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled skip-integrity-check flag for install command #2765

Merged
merged 2 commits into from
Feb 23, 2017

Conversation

bestander
Copy link
Member

@bestander bestander commented Feb 23, 2017

Summary

Sometimes you need to run full install even if integrity check returns OK.

Test plan

  1. Added unit tests

  2. manual test for skip and forece

# git clone react-native
yarn install
echo -e "# yolo\n$(cat yarn.lock)" > yarn.lock
rm -rf node_modules/chalk

yarn install
# install skipped

yarn install --skip-integrity-check
ls node_modules/chalk
head yarn.lock
# check that yarn.lock kept the comment

yarn install --force
head yarn.lock
# check that yarn.lock removed the comment
  • change a version in package.json
  • run yarn install --frozen-lockfile
  • get Your lockfile needs to be updated, but yarn was run with --frozen-lockfile.

Sometimes you need to run full install even if integrity check returns OK.
@bestander bestander merged commit bd8e326 into yarnpkg:master Feb 23, 2017
bestander added a commit that referenced this pull request Feb 23, 2017
* Enabled skip-integrity-check flag for install command

Sometimes you need to run full install even if integrity check returns OK.

* added test to --skip-integrity-checl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants