Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install package with file: protocol as default if it exists in the filesystem #2684

Closed

Conversation

voxsim
Copy link
Contributor

@voxsim voxsim commented Feb 12, 2017

This pull request should resolve #605.

Some info:

  • I added existsSync function to not spread async annotation everywhere
  • I created an instance method normalize that 'do the stuff', in detail:
    everytime we normalizePattern in package-request and it is a request we also normalize the range (if it is a file it will preprend file: and do other stuff, read the comment on the method).
  • normalizePattern is a static function and it is used in other classes, I prefered to do not touch this method

Let me know if you like it!
cheers,
Simon

@voxsim voxsim force-pushed the install_with_file_protocol_as_default branch from 154fc99 to f02c56f Compare February 12, 2017 10:27
Copy link
Member

@bestander bestander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not introduce Sync functions unless there is a really strong reason.
How bad would it be to change the function to async?

Otherwise, LGTM.

@bestander
Copy link
Member

The tests will pass when you rebase

@voxsim
Copy link
Contributor Author

voxsim commented Feb 15, 2017

@bestander I will try to do the same with async in another pull request and after that we will decide which is the best :)

@bestander
Copy link
Member

👍

@voxsim
Copy link
Contributor Author

voxsim commented Feb 19, 2017

@bestander I rebased with master and I opened another pull request #2723 ;)

@bestander
Copy link
Member

#2723 is better :)

@bestander bestander closed this Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support local file dependencies without file protocol
2 participants