Fix mktemp usage on Mac OS, and handling of environments where GPG is not available #2027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues with the install script:
-t
option formktemp
Test plan
mv /usr/bin/gpg /usr/bin/gpg-old
and run install script. Ensure output looks like:Move
/usr/bin/gpg-old
back to/usr/bin/gpg
, ensure GPG is ran:Unfortunately I don't have any Mac OS 10.10 machines available to test it out, but I think this will work as expected.
cc @BanzaiMan
Closes #2012
Closes #1984