Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cache diretory exists before using roadrunner #1902

Merged
merged 1 commit into from
Nov 17, 2016

Conversation

wyze
Copy link
Member

@wyze wyze commented Nov 17, 2016

Summary

This solves #1724. Ensures that we always have the cache directory created so roadrunner can work successfully.

Test plan

Not sure what kind of tests to add for this. @Daniel15, anything you can think of that could be added to e2e tests for this?

I was able to reduce the error with:

$ rm -rf ~/Library/Caches/Yarn
$ yarn --version

@Daniel15
Copy link
Member

Running yarn --version before doing something like yarn add was one way to replicate the bug, right? In that case, you could simply add a yarn --version call to the top of the e2e test, around here: https://github.com/yarnpkg/yarn/blob/master/end_to_end_tests/data/run-yarn-test.sh#L15

@wyze wyze force-pushed the fix-roadrunner-error branch from 65c2373 to 2a9c40a Compare November 17, 2016 00:59
@wyze
Copy link
Member Author

wyze commented Nov 17, 2016

Thanks for the direction. What I did will make the current e2e tests fail. If the fix applied in ./bin/yarn.js is merged, then it should work again.

I'll see if I can investigate a way to get this into a unit test as well.

@bestander bestander merged commit 4ce67f3 into master Nov 17, 2016
@wyze wyze deleted the fix-roadrunner-error branch November 17, 2016 13:42
@wyze wyze mentioned this pull request Nov 17, 2016
@wellyshen
Copy link

wellyshen commented Nov 17, 2016

The issue still exist, as I mentioned in #1724

@wyze wyze restored the fix-roadrunner-error branch December 9, 2016 23:05
@wyze wyze deleted the fix-roadrunner-error branch December 9, 2016 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants