Fix global add linking issue

[torifat]

Summary

~/.config/yarn/global/node_modules/.bin was not creating.

Fixes #1886

[bestander]

I'll do a 0.17.3 today

[onemen]

Shouldn't we take the value of config.binLinks instead of hard coding the value of binLinks to true.
What about all other option, config.init will set all other Boolean options to false, or to the default value from constants.

diff --git a/src/cli/commands/global.js b/src/cli/commands/global.js
--- a/src/cli/commands/global.js
+++ b/src/cli/commands/global.js
@@ -32,10 +32,15 @@ class GlobalAdd extends Add {
 const path = require('path');

 async function updateCwd(config: Config): Promise<void> {
-  await config.init({
-    cwd: config.globalFolder,
-    binLinks: true,
-  });
+  const options = {};
+  for (const key of Object.keys(config)) {
+    const val = config[key];
+    if (typeof val == 'string' || typeof val == 'boolean') {
+      options[key] = val;
+    }
+  }
+  options.cwd = config.globalFolder;
+  await config.init(options);
 }

 async function getBins(config: Config): Promise<Set<string>> {

[torifat]

Shouldn't we take the value of config.binLinks instead of hard coding the value of binLinks to true.

That would be awesome but for some reason config.binLinks is false here. Since this is a major blocker for lots of people so I decided to fix it with true for the time being.

What about all other option, config.init will set all other Boolean options to false, or to the default value from constants.

I tried what you are trying to do but it will break some other things. For example prefix. I have already asked @kittens about it. We might need some refactoring here.

[onemen]

This is odd, for me config.binLinks is always true, unless i use --no-bin-links from the command line
I did not find the place in the code to use binLinks from the config file.

The configuration is confusing, it should take the configuration in this order

• command line
• config file
• default