yarn install1.1.0 overwrites symlinks created by yarn link
#4603
Comments
BYK
pushed a commit
that referenced
this issue
Oct 26, 2017
**Summary** Actual fix: changed fs.readlink to fs.realpath when checking if a symlink is a linked dependency in package-linker.js This fixes yarn removing linked deps when installing or updating. Fixes #3288, fixes #4770, fixes #4635, fixes #4603. Potential fix for #3202. **Test plan** See #3288 (comment) for repro steps. See #3288 (comment) for my explanation of the problem. With a real world test scenario this works, but I'm unable to have it break from a unit test. I added a test in the integration suite but with the bug added back in it still passes because both generated paths are identical. I would like some help with the unit test.
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this issue
Oct 27, 2017
…#4757) **Summary** Actual fix: changed fs.readlink to fs.realpath when checking if a symlink is a linked dependency in package-linker.js This fixes yarn removing linked deps when installing or updating. Fixes yarnpkg#3288, fixes yarnpkg#4770, fixes yarnpkg#4635, fixes yarnpkg#4603. Potential fix for yarnpkg#3202. **Test plan** See yarnpkg#3288 (comment) for repro steps. See yarnpkg#3288 (comment) for my explanation of the problem. With a real world test scenario this works, but I'm unable to have it break from a unit test. I added a test in the integration suite but with the bug added back in it still passes because both generated paths are identical. I would like some help with the unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
bug
What is the current behavior?
When using
yarn link <local-package>a symlink is created innode_modules/. After runningyarn install, the symlink is removed with the public registry version of the local module.If the current behavior is a bug, please provide the steps to reproduce.
https://github.com/javinor/yarn-removes-symlinks using yarn 1.1.0
What is the expected behavior?
symlinks should not be removed when running
yarn installas happens in yarn v0.27.5Please mention your node.js, yarn and operating system version.
macOS Sierra
node 6.9.2
yarn 1.1.0 (doesn't happen with yarn 0.27.5)
The text was updated successfully, but these errors were encountered: