-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish the rename of yarn ls
to yarn list
.
#377
Conversation
_redirects
Outdated
@@ -57,3 +57,6 @@ layout: null | |||
|
|||
# Without Language | |||
{{redirectsBase | join: newline}} | |||
|
|||
# ls was renamed to list | |||
/en/docs/cli/ls https://yarnpkg.com/en/docs/cli/list 301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe do this for every language, and use a relative URI so it works properly at the preview URL:
/:language/docs/cli/ls /:language/docs/cli/list 301
Some test cases:
- https://deploy-preview-377--yarnpkg.netlify.com/en/docs/cli/ls --> should redirect to https://deploy-preview-377--yarnpkg.netlify.com/en/docs/cli/list
- https://deploy-preview-377--yarnpkg.netlify.com/fr/docs/cli/ls
- https://deploy-preview-377--yarnpkg.netlify.com/pt-BR/docs/cli/ls
(you can get this preview URL from the bottom of the pull request, where it says "deploy/netlify — Deploy preview ready!")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 11 and 13 of lang/en/docs/cli/global.md have occurrences of ls
that should be list
_data/i18n/en.yml must be changed as noted in #356
_data/guides.yml has occurrences of ls
I think #277 has all the changes but has a merge conflict
8641e34
to
9195102
Compare
No,
This PR did change this file as noted in #356. If there's anothe change to make to this file, I'm not sure what you are referring to.
Those are just internal IDs, not user-facing docs
Thanks. I missed one there. Corrected. |
@Daniel15 I've now done a force push of my proposed fix which addresses all open feedback. If this is accepted, 3 open related PRs can be closed as well that had all partially addressed what needed to be fixed. |
@markstos, sorry for a delay. |
- yarnpkg#356 did not create redirect - yarnpkg#334 duplicated some work already done in yarnpkg#333 also did not update all necessary files. - yarnpkg#277 had merge conflicts that went unaddressed. Once this is merged, all of yarnpkg#277, yarnpkg#334 and yarnpkg#356 can be closed.
3d03f2c
to
81653b1
Compare
@bestander I'm aware no outstanding feedback to be addressed on this PR, so it seems good to merge to me. I've now rebased it onto master. |
Thanks, @markstos! |
yarn list
command docs #356 did not create redirectall necessary files.
Once this is merged, both #334 and #356 can be closed.