Upgrades Chalk #659
Merged
Upgrades Chalk #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is why we don't have colors: |
4eb7516 to
e222669
Compare
|
Sorry to ask in an old merged PR, but is there any plan to revert this now that chalk/supports-color#106 has been fixed? (I'm currently manually working this around with |
|
You mean the check on |
|
Yup that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
We were behind by a major, better keep up-to-date with upstream. Practically, I hope this will fix the issue where the terminal colors aren't printed on GitHub Actions.
How did you fix it?
Manual upgrade.