Fixes errors in the PnP spec #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't seem like the spec takes into account paths on Windows, for example if is implemented as specifiedC:/foo will be treated as a bare identifier.
|
|
The spec doesn't mention the v2 implementation of "Virtual folders" that used |
merceyz
pushed a commit
that referenced
this pull request
Aug 10, 2022
* Fixes errors in the PnP spec * Explicitly suggests using `path.resolve` from the manifest location * Adds a mention about path formats * Adds a note about $$virtual
evanw
reviewed
Aug 10, 2022
|
|
||
| 4. If `relativeUrl` matches `manifest.ignorePatternData`, then | ||
|
|
||
| 1. Return **null** | ||
|
|
||
| 5. For each `referenceMap` value in `manifest.packageRegistryData` | ||
| 5. Let `relativeUrlWithDot` be `relativeUrl` prefixed with `./` or `../` as necessary |
There was a problem hiding this comment.
FYI relativeUrlWithDot is never used. I'm assuming it's supposed to be used instead of relativeUrl below.
merceyz
pushed a commit
that referenced
this pull request
Sep 21, 2022
* Fixes errors in the PnP spec * Explicitly suggests using `path.resolve` from the manifest location * Adds a mention about path formats * Adds a note about $$virtual
merceyz
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Fixes errors in the PnP spec * Explicitly suggests using `path.resolve` from the manifest location * Adds a mention about path formats * Adds a note about $$virtual
merceyz
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Fixes errors in the PnP spec * Explicitly suggests using `path.resolve` from the manifest location * Adds a mention about path formats * Adds a note about $$virtual
merceyz
pushed a commit
that referenced
this pull request
Dec 20, 2022
* Fixes errors in the PnP spec * Explicitly suggests using `path.resolve` from the manifest location * Adds a mention about path formats * Adds a note about $$virtual
merceyz
pushed a commit
that referenced
this pull request
Feb 1, 2023
* Fixes errors in the PnP spec * Explicitly suggests using `path.resolve` from the manifest location * Adds a mention about path formats * Adds a note about $$virtual
merceyz
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Fixes errors in the PnP spec * Explicitly suggests using `path.resolve` from the manifest location * Adds a mention about path formats * Adds a note about $$virtual
merceyz
pushed a commit
that referenced
this pull request
May 1, 2023
* Fixes errors in the PnP spec * Explicitly suggests using `path.resolve` from the manifest location * Adds a mention about path formats * Adds a note about $$virtual
merceyz
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Fixes errors in the PnP spec * Explicitly suggests using `path.resolve` from the manifest location * Adds a mention about path formats * Adds a note about $$virtual
merceyz
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Fixes errors in the PnP spec * Explicitly suggests using `path.resolve` from the manifest location * Adds a mention about path formats * Adds a note about $$virtual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
A couple of errors have been raised in evanw/esbuild#1985
Checklist