Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): create output directory before building #2980

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jun 3, 2021

What's the problem this PR addresses?

On Windows esbuild doesn't create the output directory recursively

cc @evanw

How did you fix it?

Create the directory before running the build

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 74fcb72 into master Jun 7, 2021
@arcanis arcanis deleted the merceyz/fix/builder-windows-folder branch June 7, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants