Move server code to ai-playground #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
reviewed
Mar 6, 2024
|
|
||
| export function registerAIPlaygroundRoutes( | ||
| { log, router }: { log: Logger; router: IRouter }, | ||
| paths: { querySourceFields: string; chat: string; apiKey: string }, |
There was a problem hiding this comment.
nitpick: i think you should just do a base url here instead
joemcelroy
reviewed
Mar 6, 2024
| @@ -0,0 +1,150 @@ | |||
| /* | |||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | |||
| * or more contributor license agreements. Licensed under the Elastic License | |||
There was a problem hiding this comment.
nitpick - can we move the the server only parts into a server/utils here? just so its easier to navigate.
Samiul-TheSoccerFan
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Looks good, tested locally. Ready to merge once the server codes moves to separate utils folder as suggested by @joemcelroy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streamFactoryin@kbn/ml-response-stream/server