Add in/out interfaces in the metadata of dumped packets #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6b0f68 to
e5c3da7
Compare
saushew
commented
Jan 19, 2024
| @@ -13,7 +13,7 @@ | |||
| namespace show | |||
| { | |||
|
|
|||
| void physicalPort() | |||
| inline void physicalPort() | |||
There was a problem hiding this comment.
Fixing: Function 'physicalPort' defined in a header file; function definitions in header files can lead to ODR violations
taitov
reviewed
Jan 22, 2024
common/icp.h
Outdated
| @@ -898,6 +899,12 @@ using response = std::tuple<unsigned int, ///< major | |||
| std::string>; ///< custom | |||
| } | |||
|
|
|||
| namespace convert | |||
| { | |||
| using response = std::map<unsigned int, ///< id | |||
There was a problem hiding this comment.
std::vector<std::tuple<>> - more effective in this place
cli/show.h
Outdated
| @@ -850,4 +850,26 @@ void shm_info() | |||
| table.print(); | |||
| } | |||
|
|
|||
| namespace convert | |||
There was a problem hiding this comment.
maybe move to convert.h or something?
cli/show.h
Outdated
| inline void logical_module() | ||
| { | ||
| interface::controlPlane controlPlane; | ||
| const auto response = controlPlane.convert_logical_module(); |
There was a problem hiding this comment.
maybe use this signature: controlPlane.convert("logical_module");?
e5c3da7 to
3729dd3
Compare
3729dd3 to
a062002
Compare
taitov
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.