Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#348] Add detailed descriptions for SSL_get_verify_result() errors. #431

Merged
merged 2 commits into from
Mar 30, 2022
Merged

[#348] Add detailed descriptions for SSL_get_verify_result() errors. #431

merged 2 commits into from
Mar 30, 2022

Conversation

Firm
Copy link
Contributor

@Firm Firm commented Mar 29, 2022

Provide more information when certificate check fails.

@Firm Firm mentioned this pull request Mar 29, 2022
Open
x4m
x4m approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@x4m x4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! Looks good to me. BTW it would be awesome to have a comment with the link to OpenSSL docs where you got those numbers..

@x4m x4m merged commit 42663bb into yandex:master Mar 30, 2022
@Firm
Copy link
Contributor Author

Firm commented Apr 22, 2022

https://www.openssl.org/docs/man1.1.1/man1/openssl-verify.html - Diagnostics part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x4m x4m x4m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Firm @x4m