-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve link issues #68
base: develop
Are you sure you want to change the base?
Conversation
- section links issue - ".md" title and TOC issue - non-ascii file name issue - link to section inside of the page itself issue 2.add extra option to disable highlightAuto() code blocks. This make results identical to GitHub and GitLab.
…kage.json.lock with updstream
@amc1999 I tried to install this repository with this branch by $ npm run build-and-install-g
> github-wikito-converter@1.5.3 build-and-install-g
> npm run build && npm install -g
> github-wikito-converter@1.5.3 build
> ./node_modules/.bin/babel src --out-dir dist --source-maps
sh: ./node_modules/.bin/babel: No such file or directory However, it works well. Thank you ! |
@yakivmospan @mchoraine |
Thank you, @hangingman That problem quite old and coming from original limedocs/limedocs-wiki-converter sources. Missing step is to do So, actual instructions to build and run locally:
I've tested it on two wiki's:
it works :) I may do another PR to update readme. |
Hey @hangingman, it's a shame but I somehow missed this PR earlier. Will take a look at it asap. Thanks for your contribution! |
Please keep in mind, some issues above I have not tested, it may be there are more work needs to be done. I've tested my own wiki with some extra unicode file names and it does work as expected.
Current highlightAuto() applied by default to code blocks and it may produce unexpected results. For example some trivial 4 front spaces console output:
may be displayed with unexpected rainbow color coding. That forces excessive use of
plaintext
and break compatibility with GitHub and GitLab. Extra--disable-highlight-auto
option fix that problem.Last, but not least: BIG thank you for github-wikito-converter