Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar/TOC longer than the screen doesn't get a scrollbar #20

Closed
jalovatt opened this issue Jun 13, 2018 · 4 comments · Fixed by #24
Closed

Sidebar/TOC longer than the screen doesn't get a scrollbar #20

jalovatt opened this issue Jun 13, 2018 · 4 comments · Fixed by #24
Assignees
Labels

Comments

@jalovatt
Copy link

As the title suggests - if the generated TOC is too long it flows past the end of the screen with no way to access the items farther down. I imagine it just needs an overflow-y: scroll somewhere, but this level of HTML is well beyond me.

Cheers.

Example: https://www.dropbox.com/s/yh4ekbz2ul7pk20/Lokasenna_GUI%202.9%20Documentation.html?dl=0

@jalovatt jalovatt changed the title Sidebar/TOC longer than the page doesn't get a scrollbar Sidebar/TOC longer than the screen doesn't get a scrollbar Jun 13, 2018
@yakivmospan
Copy link
Owner

Hey, thanks for replying.

This can be placed somewhere in html-writer.js or in default.

If I will check it out as soon as I found some free time. You can also try to play with it, never late to extend your html skills :) PR's are welcomed.

@yakivmospan yakivmospan self-assigned this Jun 13, 2018
jalovatt added a commit to jalovatt/github-wikito-converter that referenced this issue Jun 14, 2018
TOCs with more content than the window can fit weren't scrollable, so items farther down were left inaccessible.

Added a scrollbar and defined a height for the TOC container so it knows when scrolling is necessary. Hardcoded at 90% height because I couldn't figure out how to have the container's height detected automatically.
@CyborgMaster
Copy link

@yakivmospan, it looks like @jalovatt opened PR for this one at #22, may we get this merge?

@CyborgMaster
Copy link

@yakivmospan, I added a refinement of #22 in #24 with some spacing improvements. Please merge that one instead.

yakivmospan added a commit that referenced this issue Aug 20, 2018
@yakivmospan
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants