fix for #939 🔨 #967
Merged
fix for #939 🔨 #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests are failing 😢 . So its a WIP right now. |
| expect(this.el.innerHTML.indexOf('<a href="http://test.com" target="_self">lorem ipsum</a>')).toBe(0); | ||
| } else { | ||
| expect(this.el.innerHTML.indexOf('<a target="_self" href="http://test.com">lorem ipsum</a>')).toBe(0); | ||
| } |
There was a problem hiding this comment.
Yes, firefox and chrome places target="_self" (or blank) at different positions. and thus need to add a check like this.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function
setTargetSelfalong the lines ofsetTargetBlank.It is called whenever target is not suppose to be blank. The need to do this came up because of #939 . It worked well on all browsers except Firefox. So had to specifically remove target blank from the anchor tags. And one of the way I think to remove is to set it to
_self.