-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow nested contenteditables #621
Conversation
Do you mind rebasing? Our dist file situation leaves something to be desired 😞 |
i did a |
Another PR and a commit got merged into master at pretty much the exact same time you opened your PR, I'm guessing that's where the disconnect was. Agreed, I would definitely like to explore removing the dist files as soon as we can. |
Changes Unknown when pulling 71db944 on phiggins42:nested-toolbar into * on daviferreira:master*. |
allow nested contenteditables
i think i got it this time. github pattern noob, sorry for the ugh commits. was confused. +1 to figuring out how to not need to keep the dist/ files in branch (in tags makes sense, doesn't npm et al use whatever is current as the dist file? unsure). thanks for quick merge. |
allow nested contenteditables
all the tests remain passing, can add another for the case. added a random demo/ file to show the usecase.