-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web UI to support querying from browsers. #250
Conversation
PR was closed due to manual error. Reopening now. Please continue to review. |
…the search is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An incomplete review, but something to get started with. You'll also want to merge main in at some point since there've been some large changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit msg: Add Web UI to support querying from browsers. (#250)
?
…th variable NODEJS_BIN_DIR in Taskfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my end. Kindly please review and merge.
Description
webui
and depedency configurationnodejs
.Validation performed
Build and Load + Stats Visualization
task
command and observed all tasks to complete without critical error.<BUILD_DIR>/clp-package/sbin/start-clp.sh
and observed that all components started properly.http://localhost:4000
on the running Linux host and observed the web page to load without error messages in the browser debugger console. To be exact, the access was done via an SSH port-forwarding channel since the test was done on another Windows machine.hadoop-24hrs/logs/i-00c90a0f
with<BUILD_DIR>/clp-package/sbin/compress.sh
and observed no error.webui
via command<BUILD_DIR>/clp-package/sbin/start-clp.sh webui
and observed messages showing the component has been stopped.<BUILD_DIR>/clp-package/etc/clp-config.yml
to specify custom port9999
forwebui
. e.g.,Query
121.0.2277.81
and observed page to load and show query User Interface.FsDatasetAsyncDiskService
and Time Range from Unix epoch to date which returned 172 results. Toggle browser search byCtrl + F
with the same search string and observed every result entry has matching part highlighted. With MongoDB Compass, verified that the results count (172) matched total document count for the search job results collection in MongoDB.fsdatasetasyncdiskservice
and observed a "No results found" message presented in the UI, which is expected because the search is not case-insensitive.DirectoryScanner
, and as the query is progressing, quickly performed another search withFsDatasetAsyncDiskService
. Observed no race condition using the browser highlight method described in Step 2.Logging
<BUILD_DIR>/clp-package/sbin/start-clp.sh results_cache
to stop the MongoDB "Results Cache", which is a dependency of the WebUI.http://localhost:4000
and observed the web page to keep displaying a loading animation because the Meteor.js server is unable to connect to the MongoDB to retrieve user information.webui_error*.log
andwebui*.log
inside<BUILD_DIR>/clp-package/var/log/<host>/webui
and found the operation sequences and errors getting logged properly.