Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only search archives within the search time range; Add begin and end timestamp to archive metadata. #138

Merged
merged 9 commits into from
Jul 25, 2023
Merged

Only search archives within the search time range; Add begin and end timestamp to archive metadata. #138

merged 9 commits into from
Jul 25, 2023

Conversation

abvarun226
Copy link
Contributor

@abvarun226 abvarun226 commented Jul 10, 2023 •
edited
Loading

Description

When using MySQL as metadata db, only retrieve archive directories that have logs in the given search time window. This will improve search performance.

Validation performed

Functional tests on Ubuntu bionic.

@Yadumathur
Copy link

@kirkrodrigues / @jackluo923 As discussed yesterday can you please review the PR and let us know if you further see any changes in PR or its okay to be merged ?
As provided description this is to improve the search performance.

@Yadumathur Yadumathur mentioned this pull request Jul 11, 2023
Closed
@Yadumathur
Copy link

ref : #139

kirkrodrigues
kirkrodrigues requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I've raised a few concerns, but overall, the idea sounds good.

components/core/src/GlobalMySQLMetadataDB.hpp Outdated Show resolved Hide resolved
components/core/src/GlobalMySQLMetadataDB.cpp Outdated Show resolved Hide resolved
components/core/src/clg/clg.cpp Show resolved Hide resolved
components/core/src/clp/decompression.cpp Outdated Show resolved Hide resolved
components/core/src/GlobalSQLiteMetadataDB.hpp Outdated Show resolved Hide resolved
kirkrodrigues
kirkrodrigues requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one missed change, and hopefully we can get the archive metadata change in before merging.

components/core/src/GlobalSQLiteMetadataDB.cpp Outdated Show resolved Hide resolved
components/core/src/GlobalMySQLMetadataDB.cpp Outdated Show resolved Hide resolved
@kirkrodrigues kirkrodrigues merged commit bbe55be into y-scope:main Jul 25, 2023
@kirkrodrigues
Copy link
Member

Thanks for your contribution!

@kirkrodrigues kirkrodrigues changed the title Retrieve archives that have logs in the given search time window Only search archives within the search time range; Add begin and end timestamp to archive metadata. May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadumathur Yadumathur Yadumathur left review comments

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abvarun226 @Yadumathur @kirkrodrigues