Minor tweaks to fix setup on macOS #107
Conversation
components/core/CMakeLists.txt
Outdated
| @@ -130,7 +130,13 @@ else() | |||
| endif() | |||
|
|
|||
| # Find and setup msgpack | |||
| find_package(msgpackc-cxx 5.0.0 REQUIRED) | |||
| if(APPLE) | |||
| execute_process(COMMAND brew --prefix msgpack-cxx OUTPUT_VARIABLE PREFIX_MSGPACK_CXX) | |||
There was a problem hiding this comment.
msgpack-cxx installed through brew does not come with the pkg-config file, so it cannot be automatically detected.
There was a problem hiding this comment.
Based on our offline discussion, do you think this is necessary if we add msgpack to our macOS dependencies?
There was a problem hiding this comment.
I've done a bit of searching and it seems like a name mix-up on the msgpack side (msgpack#974). They are aware of the issue and they are actively fixing it (see msgpack#1043, only closed last week). They released the fix in a higher version, i.e., 6.0.0. But unfortunately, msgpack-cxx v6.0.0 still does not have a .pc file.
Therefore, I would recommend brew --prefix approach for now instead of the error-prone co-existence of both c and cxx library.
components/core/CMakeLists.txt
Outdated
| string(STRIP "${PREFIX_MSGPACK_CXX}" PREFIX_MSGPACK_CXX) | ||
| endif() | ||
| find_package(msgpackc-cxx 5.0.0 REQUIRED | ||
| HINTS ${PREFIX_MSGPACK_CXX} |
There was a problem hiding this comment.
For other systems, PREFIX_MSGPACK_CXX would just be blank, which will not harm the search process.
components/core/CMakeLists.txt
Outdated
| @@ -130,7 +130,13 @@ else() | |||
| endif() | |||
|
|
|||
| # Find and setup msgpack | |||
| find_package(msgpackc-cxx 5.0.0 REQUIRED) | |||
| if(APPLE) | |||
| execute_process(COMMAND brew --prefix msgpack-cxx OUTPUT_VARIABLE PREFIX_MSGPACK_CXX) | |||
There was a problem hiding this comment.
Based on our offline discussion, do you think this is necessary if we add msgpack to our macOS dependencies?
References
None.
Description
Hey there, I've added several tweaks to fix errors when building
clp-coreon macOS.Validation performed
Tested on macOS.