Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network_reader_illegal_offset unit test failure on macOS #519

Closed
kirkrodrigues opened this issue Aug 18, 2024 · 1 comment · Fixed by #517
Closed

network_reader_illegal_offset unit test failure on macOS #519

kirkrodrigues opened this issue Aug 18, 2024 · 1 comment · Fixed by #517
Labels
bug Something isn't working

Comments

@kirkrodrigues
Copy link
Member

Bug

The network_reader_illegal_offset unit test is failing on GH's macOS runners. The issue is being investigated and mitigated in #517.

CLP version

1b67fdb

Environment

Any macOS GH runner

Reproduction steps

Run the clp-core-build-macos workflow on a macOS GH runner.
@kirkrodrigues kirkrodrigues added the bug Something isn't working label Aug 18, 2024
@kirkrodrigues kirkrodrigues mentioned this issue Aug 18, 2024
Merged
@LinZhihao-723 LinZhihao-723 mentioned this issue Aug 21, 2024
Merged
@LinZhihao-723
Copy link
Member

The investigation shows that the issue only happens in some versions of libcurl on macOS, where HTTP return code 416 is not treated as CURL_HTTP_RETURNED_ERROR. In Ubuntu 20.04 and 22.04, we tried to update libcurl to 8.9.1 (which is the latest release when this comment was written) and it didn't reproduce.
Therefore, we suspect this is a macOS-specific issue and will handle it with specialized check for macOS only.

@AVMatthews AVMatthews mentioned this issue Aug 21, 2024
Merged
@LinZhihao-723 LinZhihao-723 mentioned this issue Aug 21, 2024
Merged
@kirkrodrigues kirkrodrigues mentioned this issue Aug 22, 2024
Merged
jackluo923 pushed a commit to jackluo923/clp that referenced this issue Dec 4, 2024
@LinZhihao-723 @kirkrodrigues
core: Add support for retrieving CURL error messages, handle unexpect…
8ec439a 
…ed CURL return code on macOS, and log such codes in tests (fixes y-scope#519). (y-scope#517)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@kirkrodrigues @LinZhihao-723