Skip to content

Commit

Permalink
Rename private methods to be prefixed with _
Browse files Browse the repository at this point in the history
  • Loading branch information
gibber9809 committed Jan 17, 2025
1 parent 3e50655 commit d48687f
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
logger = get_task_logger(__name__)


def make_core_clp_command_and_env_vars(
def _make_core_clp_command_and_env_vars(
clp_home: Path,
worker_config: WorkerConfig,
archive_id: str,
Expand All @@ -41,7 +41,7 @@ def make_core_clp_command_and_env_vars(
return command, None


def make_core_clp_s_command_and_env_vars(
def _make_core_clp_s_command_and_env_vars(
clp_home: Path,
worker_config: WorkerConfig,
archive_id: str,
Expand Down Expand Up @@ -86,7 +86,7 @@ def make_core_clp_s_command_and_env_vars(
return command, env_vars


def make_command_and_env_vars(
def _make_command_and_env_vars(
clp_home: Path,
worker_config: WorkerConfig,
archive_id: str,
Expand All @@ -97,11 +97,11 @@ def make_command_and_env_vars(
storage_engine = worker_config.package.storage_engine

if StorageEngine.CLP == storage_engine:
command, env_vars = make_core_clp_command_and_env_vars(
command, env_vars = _make_core_clp_command_and_env_vars(
clp_home, worker_config, archive_id, search_config
)
elif StorageEngine.CLP_S == storage_engine:
command, env_vars = make_core_clp_s_command_and_env_vars(
command, env_vars = _make_core_clp_s_command_and_env_vars(
clp_home, worker_config, archive_id, search_config
)
else:
Expand Down Expand Up @@ -194,7 +194,7 @@ def search(
clp_home = Path(os.getenv("CLP_HOME"))
search_config = SearchJobConfig.parse_obj(job_config)

task_command, core_clp_env_vars = make_command_and_env_vars(
task_command, core_clp_env_vars = _make_command_and_env_vars(
clp_home=clp_home,
worker_config=worker_config,
archive_id=archive_id,
Expand Down

0 comments on commit d48687f

Please sign in to comment.