-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Explicitly use ubunutu-22.04 to test wheels for Python3.7. #52
Conversation
WalkthroughThe pull request introduces a modification to the GitHub Actions workflow configuration, specifically targeting the Changes
The modification ensures a fixed Ubuntu version for test execution, potentially improving reproducibility and preventing unexpected variations caused by automatic updates to the latest Ubuntu runner. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/package.yaml (1)
45-47
: Consider future-proofing the Python 3.7 testing strategy.Given that Python 3.7 reached end-of-life on June 27, 2023, and you're already downloading Python 3.8 wheels for testing, it might be worth considering:
- Adding a comment explaining why
ubuntu-22.04
is specifically required- Creating a timeline for phasing out Python 3.7 support entirely
Add a comment above the matrix configuration:
strategy: matrix: + # Using ubuntu-22.04 as it's the last LTS release supporting Python 3.7 os: [macos-13, ubuntu-22.04]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/package.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: test (ubuntu-latest, 3.11)
- GitHub Check: test (ubuntu-latest, 3.8)
- GitHub Check: test-python37 (ubuntu-22.04, 3.7)
- GitHub Check: test-python37 (macos-13, 3.7)
- GitHub Check: test (macos-latest, 3.8)
🔇 Additional comments (1)
.github/workflows/package.yaml (1)
45-45
: The change to useubuntu-22.04
is appropriate and well-reasoned.The explicit version specification for Ubuntu ensures consistent testing environment for Python 3.7, addressing the compatibility issue with Ubuntu 24.04. This is a necessary change as Python 3.7 is not supported in newer Ubuntu versions.
Description
Reference: https://github.com/y-scope/clp-loglib-py/actions/runs/12837435781/job/35801116566?pr=51
ubuntu-latest has been upgraded to Ubuntu 24.04 which doesn't support Python 3.7. This PR changes Python 3.7's testing env from
ubuntu-latest
toubuntu-22.04
explicitly to ensure the workflow can be successfully launched.Validation performed
Summary by CodeRabbit