Make URL builder use site_url() to get correct http scheme #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -505,7 +505,7 @@ static function get_cache_option_name( $src_hash ) { | |||
| static function get_dependency_minified_url( array $deps, $type ) { | |||
| $src_hash = self::hash_array( wp_list_pluck( $deps, 'src' ) ); | |||
| $ver_hash = self::hash_array( wp_list_pluck( $deps, 'ver' ) ); | |||
| $src = trailingslashit( get_option( 'home' ) . DIRECTORY_SEPARATOR . self::$options['endpoint'] ); | |||
| $src = esc_url( trailingslashit( site_url( self::$options['endpoint'] ) ) ); | |||
There was a problem hiding this comment.
@topher1kenobe I don't believe this should be esc_url this here. It will get escaped later when output.
|
Also fixes #50. |
|
See also #54. |
| @@ -1 +0,0 @@ | |||
| bin/.travis.yml | |||
There was a problem hiding this comment.
Why the deletion of this symlink?
|
@topher1kenobe in think you meant to merge this on your fork instead. |
|
Yeah, I'm working on fixing it. |
|
Done. I reset the branch back to c579d69. |
git reset --hard c579d699e9ba9facdeee721675e51930c0c6f839
git push -f |
|
I did as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@westonruter could you review and let me know what you think?