Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22817: Dashboards of users without script right have translation calls in gadget titles #3839

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michitux
Copy link
Contributor

Jira URL

https://jira.xwiki.org/browse/XWIKI-22817

Changes

Description

  • Catch titles with just a translation call and load the translation directly without evaluating any script.
  • Adapt the required rights analyzer.
  • Change the gadget wizard to produce a translation macro instead of a Velocity call.

Clarifications

  • The change in the JavaScript code isn't strictly necessary, but as we support wiki syntax in the titles, anyway, I thought it could be a nice solution to have something better supported for non-script users. The remaining changes are still necessary for fixing existing dashboards.

Screenshots & Video

Executed Tests

LANG=C.UTF-8 mvn clean install -Pdocker,legacy,integration-tests,snapshotModules,quality -pl :xwiki-platform-dashboard-macro,:xwiki-platform-dashboard-test-docker

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • stable-16.10.x

…n calls in gadget titles

* Catch titles with just a translation call and load the translation
  directly without evaluating any script.
* Adapt the required rights analyzer.
* Change the gadget wizard to produce a translation macro instead of a
  Velocity call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant