XWIKI-22580: New release input fields have no text alternative (#3580) (

#3830)

(cherry picked from commit d3227ee)

Co-authored-by: LucasC <lucas.charpentier@xwiki.com>

xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/PropertyClass.java

@@ -294,6 +294,11 @@ public void displayCustom(StringBuffer buffer, String fieldName, String prefix,
                 ScriptContext.ENGINE_SCOPE);
             scontext.setAttribute("object", new com.xpn.xwiki.api.Object(object, context), ScriptContext.ENGINE_SCOPE);
             scontext.setAttribute("type", type, ScriptContext.ENGINE_SCOPE);
+            // This is a text alternative fallback to explain what the input is about. 
+            // If the input has already been labelled in another way, this fallback will be ignored by Assistive Techs.
+            scontext.setAttribute("aria-label",
+                localizePlainOrKey("core.model.xclass.editClassProperty.textAlternative",
+                    this.getTranslatedPrettyName(context)), ScriptContext.ENGINE_SCOPE);
 
             BaseProperty prop = (BaseProperty) object.safeget(fieldName);
             if (prop != null) {

xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/StringClass.java

@@ -111,6 +111,11 @@ public void displayEdit(StringBuffer buffer, String name, String prefix, BaseCol
         input.setID(prefix + name);
         input.setSize(getSize());
         input.setDisabled(isDisabled());
+        /* This is a text alternative fallback to explain what the input is about. 
+         If the input has already been labelled in another way, this fallback will be ignored by Assistive Techs.
+         */
+        input.addAttribute("aria-label", localizePlainOrKey("core.model.xclass.editClassProperty.textAlternative",
+            this.getTranslatedPrettyName(context)));
 
         if (isPicker()) {
             displayPickerEdit(input);

xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/ApplicationResources.properties

@@ -601,6 +601,7 @@ core.importer.saveDocumentComment=Imported from XAR
 core.importer.securitySettingsChanged=Security settings have changed during the import. You will need <a href="{0}">to authenticate</a> in order to continue to administrate the wiki.
 core.importer.importAsBackup=Import as backup package
 
+core.model.xclass.editClassProperty.textAlternative=Edit the property "{0}".
 core.model.xclass.deleteClassProperty.versionSummary=Removed class property "{0}"
 core.model.xclass.disableClassProperty.versionSummary=Disabled class property "{0}"
 core.model.xclass.enableClassProperty.versionSummary=Enabled class property "{0}"

xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/api/ContextTest.java

@@ -73,7 +73,7 @@ void setDisplayMode() throws Exception
         context.setDisplayMode("edit");
 
         // We verify that the result contains a form input
-        assertEquals("<input size='5' id='space.page_0_prop' value='value' name='space.page_0_prop' " + "type='text'/>",
+        assertEquals("<input size='5' id='space.page_0_prop' aria-label='core.model.xclass.editClassProperty.textAlternative' value='value' name='space.page_0_prop' " + "type='text'/>",
             document.display("prop", xcontext));
 
         assertEquals("edit", context.getDisplayMode());

xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentTest.java

@@ -598,7 +598,7 @@ public void display()
         this.document.setSyntax(Syntax.XWIKI_2_0);
 
         assertEquals(
-            "{{html clean=\"false\" wiki=\"false\"}}<input size='30' id='Space.Page_0_string' value='string' name='Space.Page_0_string' type='text'/>{{/html}}",
+            "{{html clean=\"false\" wiki=\"false\"}}<input size='30' id='Space.Page_0_string' aria-label='core.model.xclass.editClassProperty.textAlternative' value='string' name='Space.Page_0_string' type='text'/>{{/html}}",
             this.document.display("string", "edit", this.oldcore.getXWikiContext()));
 
         assertEquals("string", this.document.display("string", "view", this.oldcore.getXWikiContext()));
@@ -634,7 +634,7 @@ public void display1020()
 
         assertEquals("string", this.document.display("string", "view", this.oldcore.getXWikiContext()));
         assertEquals(
-            "{pre}<input size='30' id='Space.Page_0_string' value='string' name='Space.Page_0_string' type='text'/>{/pre}",
+            "{pre}<input size='30' id='Space.Page_0_string' aria-label='core.model.xclass.editClassProperty.textAlternative' value='string' name='Space.Page_0_string' type='text'/>{/pre}",
             this.document.display("string", "edit", this.oldcore.getXWikiContext()));
 
         assertEquals("<p>area</p>", this.document.display("area", "view", this.oldcore.getXWikiContext()));
@@ -651,7 +651,7 @@ public void displayTemplate20()
 
         assertEquals("string", this.document.display("string", "view", this.oldcore.getXWikiContext()));
         assertEquals(
-            "<input size='30' id='Space.Page_0_string' value='string' name='Space.Page_0_string' type='text'/>",
+            "<input size='30' id='Space.Page_0_string' aria-label='core.model.xclass.editClassProperty.textAlternative' value='string' name='Space.Page_0_string' type='text'/>",
             this.document.display("string", "edit", this.oldcore.getXWikiContext()));
 
         assertEquals("<p>area</p>", this.document.display("area", "view", this.oldcore.getXWikiContext()));

xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/PropertyClassTest.java

@@ -27,6 +27,7 @@
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.xwiki.localization.ContextualLocalizationManager;
 import org.xwiki.display.internal.DocumentDisplayer;
 import org.xwiki.display.internal.DocumentDisplayerParameters;
 import org.xwiki.job.event.status.JobProgressManager;
@@ -108,6 +109,7 @@ public void before() throws Exception
         this.oldCore.getMocker().registerMockComponent(EntityReferenceSerializer.TYPE_STRING, "compactwiki");
         this.oldCore.getMocker().registerMockComponent(DocumentReferenceResolver.TYPE_STRING, "currentmixed");
         this.oldCore.getMocker().registerMockComponent(EntityReferenceSerializer.TYPE_STRING, "local");
+        this.oldCore.getMocker().registerMockComponent(ContextualLocalizationManager.class);
 
         DocumentReference contextDocumentReference = new DocumentReference("wiki", "XWiki", "Context");
         this.oldCore.getXWikiContext().setDoc(new XWikiDocument(contextDocumentReference));

xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/StringClassTest.java

@@ -21,6 +21,7 @@
 
 import org.junit.jupiter.api.Test;
 import org.mockito.Mock;
+import org.xwiki.localization.ContextualLocalizationManager;
 import org.xwiki.model.reference.DocumentReference;
 import org.xwiki.model.reference.LocalDocumentReference;
 
@@ -50,8 +51,11 @@ class StringClassTest
     private XWikiURLFactory urlFactory;
 
     @Test
-    void displayEdit()
+    void displayEdit() throws Exception
     {
+        // Setup
+        this.oldCore.getMocker().registerMockComponent(ContextualLocalizationManager.class);
+
         XWikiContext xWikiContext = this.oldCore.getXWikiContext();
         xWikiContext.setURLFactory(this.urlFactory);
         when(this.oldCore.getSpyXWiki()
@@ -70,14 +74,14 @@ void displayEdit()
         StringBuffer stringBuffer = new StringBuffer();
         stringClass.displayEdit(stringBuffer, fieldName, spaceName + "." + pageName + "_0_", baseClass,
             xWikiContext);
-        assertEquals("<input "
+        assertEquals("<input aria-label='core.model.xclass.editClassProperty.textAlternative' "
             + "onfocus='new ajaxSuggest(this, &#123;script:&#34;\\/a\\/b?xpage=suggest&#38;"
             + "classname=%22%20%2B%20alert%281%29%20%2B%20%22.WebHome&#38;fieldname=test&#38;firCol=-&#38;"
             + "secCol=-&#38;&#34;, varname:&#34;input&#34;} )' "
-            + "size='30' "
-            + "id='&#34; + alert(1) + &#34;.WebHome_0_test' "
             + "class='suggested' "
+            + "id='&#34; + alert(1) + &#34;.WebHome_0_test' "
             + "name='&#34; + alert(1) + &#34;.WebHome_0_test' "
+            + "size='30' "
             + "type='text'/>", stringBuffer.toString());
     }
 }

xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/displayer_date.vm

@@ -27,7 +27,8 @@
     'name': $id,
     'value': $value,
     'disabled': $disabled,
-    'data-format': $format
+    'data-format': $format,
+    'aria-label': $aria-label
   })
   #set ($picker = $field.getProperty('picker').value == 1)
   #if ($picker)