Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup: PrettyPrint, Render, and Parse #12

Merged
merged 13 commits into from
Aug 2, 2023
Merged

Speedup: PrettyPrint, Render, and Parse #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1a48206
Use string builder for Render and PrettyPrint
matthinrichsen-wf Aug 1, 2023
58181c5
Use runes instead of strings for current char comparison
matthinrichsen-wf Aug 1, 2023
48cded0
Use sets instead of arrays
matthinrichsen-wf Aug 1, 2023
a7856f4
Build the regex exactly once
matthinrichsen-wf Aug 1, 2023
67ab918
use token as a rune array
matthinrichsen-wf Aug 1, 2023
2487d24
Do the []rune conversion once
matthinrichsen-wf Aug 1, 2023
cf0b8c4
doubleChar as a []rune as well
matthinrichsen-wf Aug 1, 2023
c5ae68c
Token Value is a []rune too
matthinrichsen-wf Aug 1, 2023
a3322a3
Give size and cap for fTokens
matthinrichsen-wf Aug 1, 2023
8b2cfd9
Format code and move back to just strings
matthinrichsen-wf Aug 2, 2023
cf1a0ed
Format using gofumpt -l -d -w ./
matthinrichsen-wf Aug 2, 2023
7a624e7
Add test for non-nil tokens and fix issue
matthinrichsen-wf Aug 2, 2023
eecd1e3
Code optimization based on pull request #12
xuri Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->
<!--- See how your change affects other areas of the code, etc. -->

## Types of changes

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Contributions are welcome! Open a pull request to fix a bug, or open an issue to

## Credits

EFP (Excel Formula Parser) is a Golang port of [E. W. Bachtal's](https://ewbi.blogs.com/develops/2004/12/excel_formula_p.html) Excel formula parser.
EFP (Excel Formula Parser) is a Go language port of E. W. Bachtal's Excel formula parser.

## Licenses

Expand Down
Loading