Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directive breaking change false-positive #47

Merged
merged 2 commits into from
Jan 7, 2022
Merged

directive breaking change false-positive #47

merged 2 commits into from
Jan 7, 2022

Conversation

haruska
Copy link
Contributor

@haruska haruska commented Jan 7, 2022 •
edited
Loading

When checking directive arguments for equivalence, check the type signature strings instead of the type graph objects.

Fixes #48.

@haruska haruska mentioned this pull request Jan 7, 2022
Closed
@haruska haruska marked this pull request as ready for review January 7, 2022 18:42
@swalkinshaw swalkinshaw merged commit 535ba88 into xuorig:master Jan 7, 2022
@haruska haruska deleted the unchanged_directive_breaking branch January 7, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unchanged directive marked as breaking change
2 participants
@haruska @swalkinshaw