Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facebook & google login #10

Closed
leonardosetiadi opened this issue Jul 3, 2019 · 9 comments
Closed

facebook & google login #10

leonardosetiadi opened this issue Jul 3, 2019 · 9 comments

Comments

@leonardosetiadi
Copy link

my facebook & google login is not working, can you help?

@xtools-at
Copy link
Owner

can you be a little more specific? what's happening?

@leonardosetiadi
Copy link
Author

leonardosetiadi commented Jul 3, 2019 via email

@xtools-at
Copy link
Owner

does the oauth login page open in the browser, or within the app?
can you provide a link to your web app?

@leonardosetiadi
Copy link
Author

leonardosetiadi commented Jul 3, 2019 via email

Repository owner deleted a comment from leonardosetiadi Jul 3, 2019
@xtools-at
Copy link
Owner

xtools-at commented Jul 3, 2019

it makes sense if you think about it - you leave the app's browser context, the link opens in safari and everything else is only happening there, including the callback.
you could try extending/removing the allowedOrigin logic after this line in ViewController and see if it works out for you:
// restrict navigation to target host, open external links in 3rd party apps

EDIT: pushed an update to develop to support multiple origins, maybe try adding facebook- and google-urls to the Constants.swift > allowedOrigins array

@xtools-at
Copy link
Owner

any feedback on this?

@xtools-at
Copy link
Owner

@leonardosetiadi any feedback on this?

@xtools-at
Copy link
Owner

Closed due to lack of feedback from OP

@anirudhsirohi1729
Copy link

google login does'nt work even after extending and removing the func u mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants