Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search result count to SearchAddon #3716

Merged
merged 32 commits into from
Mar 31, 2022
Merged

Add search result count to SearchAddon #3716

merged 32 commits into from
Mar 31, 2022

Conversation

meganrogge
Copy link
Member

@meganrogge meganrogge commented Mar 28, 2022 •
edited
Loading

fixes #1659

@meganrogge
Copy link
Member Author

We can either do it this way or could return the count from findNext/findPrevious instead of a boolean

@meganrogge meganrogge self-assigned this Mar 28, 2022
@meganrogge meganrogge added this to the 4.19.0 milestone Mar 28, 2022
@meganrogge meganrogge requested a review from Tyriar March 28, 2022 19:41
Tyriar
Tyriar reviewed Mar 28, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we only know the total count if decorations are on? What would this return if it's off so only a single result is selected?

@meganrogge
Copy link
Member Author

meganrogge commented Mar 28, 2022 •
edited
Loading

When decorations are on, all of that work has already been done, so it costs nothing extra to get this info.

Would have to find all when decorations are not on. Do we want to support that?

@meganrogge
Copy link
Member Author

meganrogge commented Mar 29, 2022 •
edited
Loading

We discussed and agreed upon:

Tyriar
Tyriar requested changes Mar 29, 2022
View reviewed changes
addons/xterm-addon-search/src/SearchAddon.ts Outdated Show resolved Hide resolved
addons/xterm-addon-search/src/SearchAddon.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge requested a review from Tyriar March 30, 2022 01:59
Tyriar
Tyriar approved these changes Mar 30, 2022
View reviewed changes
addons/xterm-addon-search/src/SearchAddon.ts
@@ -87,6 +87,7 @@ export class SearchAddon implements ITerminalAddon {
}, 200);
}
});
this.onDidChangeResults((results) => console.log(results));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think that was outdated as I don't see it there

@meganrogge meganrogge merged commit 842f4c2 into xtermjs:master Mar 31, 2022
This was referenced Jul 2, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
4.19.0
Development

Successfully merging this pull request may close these issues.

Search addon: Return the number of results of a search
2 participants
@meganrogge @Tyriar