Change textBaseline from "ideographic" to "bottom" #3356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've installed Powerline-supported fonts. While this update helps with Firefox, it appears to break the proper alignment in Chrome that was added in PR #3279. Powerline on Firefox before this PR:
Powerline on Firefox after this PR:
Powerline on Chrome before this PR:
Powerline on Chrome after this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
textBaselinefromideographictobottomto resolve Issue #3353. I made changes in all places wheremiddlewas changed toideographicas part of PR #3279.In my testing, the update worked as expected. However, I don't know whether there are assumptions elsewhere that this would break. Any feedback would be appreciated if there is further testing I should conduct and/or additional changes that should be made.
I tried using the code in https://github.com/xtermjs/xterm.js/wiki/Powerline-fonts to test whether powerline fonts continue to work as expected, but the fonts were not supported by my browser, either with or without the change in this PR. I tried on Chrome as well with no success. I also tried on Windows instead of Ubuntu, and encountered the same issue.