Fix #1773 - drawBoldTextInBrightColors is not taken into account with DOM renderer #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Mar 8, 2019
| @@ -17,6 +17,7 @@ export const CURSOR_STYLE_UNDERLINE_CLASS = 'xterm-cursor-underline'; | |||
|
|
|||
| export class DomRendererRowFactory { | |||
| constructor( | |||
| private _terminal: ITerminal, | |||
There was a problem hiding this comment.
I've been slowly trying to break this pattern of passing ITerminal around everywhere (#1627), I think passing in ITerminalOptions here would be preferable as we never reassign that on Terminal.
|
Makes sense, I'll make the changes Sunday when I'm back home ??
Get Outlook for Android<https://aka.ms/ghei36>
________________________________
From: Daniel Imms <notifications@github.com>
Sent: Friday, March 8, 2019 5:07:05 PM
To: xtermjs/xterm.js
Cc: Bruno Ribeiro; Author
Subject: Re: [xtermjs/xterm.js] Fix #1773 - drawBoldTextInBrightColors is not taken into account with DOM renderer (#1961)
@Tyriar requested changes on this pull request.
________________________________
In src/renderer/dom/DomRendererRowFactory.ts<#1961 (comment)>:
@@ -17,6 +17,7 @@ export const CURSOR_STYLE_UNDERLINE_CLASS = 'xterm-cursor-underline';
export class DomRendererRowFactory {
constructor(
+ private _terminal: ITerminal,
I've been slowly trying to break this pattern of passing ITerminal around everywhere (#1627<#1627>), I think passing in ITerminalOptions here would be preferable as we never reassign that on Terminal.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1961 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APWm2wuxMP3Xz7Pm9iQaho61EhE8RlAbks5vUpi5gaJpZM4bkJzn>.
|
|
Sounds good, thanks a bunch as always 😃 |
|
Circular dependency removed, and verified that it still works! |
Tyriar
approved these changes
Mar 29, 2019
10 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1773 by taking into account the terminal options