Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGL ligatures are storing wrong color for cells, causing bad rendering sometimes when type ahead is used in VS Code #3288

Closed
Tyriar opened this issue Apr 2, 2021 · 2 comments · Fixed by #5209
Closed

WebGL ligatures are storing wrong color for cells, causing bad rendering sometimes when type ahead is used in VS Code #3288

Tyriar opened this issue Apr 2, 2021 · 2 comments · Fixed by #5209
Assignees
@Tyriar
Labels
area/addon/ligatures area/addon/webgl type/bug Something is misbehaving
Milestone
6.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 2, 2021

Screen Shot 2021-04-02 at 3 31 25 PM
@Tyriar Tyriar added this to the 4.12.0 milestone Apr 2, 2021
@Tyriar Tyriar self-assigned this Apr 2, 2021
This was referenced Apr 2, 2021
Closed
Open
@Tyriar
Copy link
Member Author

Tyriar commented May 5, 2021

We probably won't be adopting ligatures in VS Code for at least the next month, so pushing this.

@Tyriar Tyriar modified the milestones: 4.12.0, 4.13.0 May 5, 2021
@Tyriar Tyriar modified the milestones: 4.13.0, 4.14.0 Jun 24, 2021
@Tyriar Tyriar removed this from the 4.14.0 milestone Sep 1, 2021
@Tyriar Tyriar mentioned this issue Dec 22, 2021
Closed
8 tasks
@Tyriar
Copy link
Member Author

Tyriar commented Aug 3, 2022

Might be the same as #3303?

@Tyriar Tyriar mentioned this issue Aug 3, 2022
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 4, 2024
@Tyriar
Ensure last ligature cell is updated
129cbd8 
Fixes xtermjs#5207
Fixes xtermjs#3288
Fixes xtermjs#5206
Part of microsoft/vscode#233005
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 4, 2024
@Tyriar
Ensure last ligature cell is updated
7fab293 
Fixes xtermjs#3288
Fixes xtermjs#5206
Part of microsoft/vscode#233005
@Tyriar Tyriar mentioned this issue Nov 4, 2024
Merged
@Tyriar Tyriar added this to the 6.0.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/ligatures area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Ensure last ligature cell is updated Tyriar/xterm.js
1 participant
@Tyriar