Non-ASCII text is displayed with black color

[hwooo]

Details

• Browser and browser version: Terminus (It uses xterm for terminal frontend)
• OS version: Windows 10
• xterm.js version: 3.13.0-beta1

Steps to reproduce

1. Type non-ASCII(Korean) text on Terminus terminal
2. It is displayed with black color so it is hard to distinguish

[Eugeny]

Can confirm - xterm renders them black independently of the current color palette

[Tyriar]

This appears to be related to the canvas renderer

[Tyriar]

@jerch might have been the cell data changes?

[jerch]

The problematic code is:

xterm.js/src/renderer/BaseRenderLayer.ts

Lines 317 to 333 in f4bbfc3

	if (cell.isInverse()) {
	if (cell.isBgDefault()) {
	this._ctx.fillStyle = this._colors.background.css;
	} else if (cell.isBgRGB()) {
	this._ctx.fillStyle = `rgb(${AttributeData.toColorRGB(cell.getBgColor()).join(',')})`;
	} else {
	this._ctx.fillStyle = this._colors.ansi[cell.getBgColor()].css;
	}
	} else if (cell.isFgRGB()) {
	this._ctx.fillStyle = `rgb(${AttributeData.toColorRGB(cell.getFgColor()).join(',')})`;
	} else if (cell.isFgPalette()) {
	let fg = cell.getFgColor();
	if (terminal.options.drawBoldTextInBrightColors && cell.isBold() && fg < 8) {
	fg += 8;
	}
	this._ctx.fillStyle = this._colors.ansi[fg].css;
	}

It misses handling of the default colors.