Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ASCII text issue #789

Closed
hwooo opened this issue Apr 29, 2019 · 5 comments
Closed

Non-ASCII text issue #789

hwooo opened this issue Apr 29, 2019 · 5 comments

Comments

@hwooo
Copy link

hwooo commented Apr 29, 2019

OS: Windows 10

Honeycam 2019-04-29 19-40-41
Honeycam 2019-04-29 19-47-03

In hterm mode, If I type non-ASCII(Korean) text in the terminal, it appears bottom or top of the screen and doesn't disappear.

Honeycam 2019-04-29 19-55-37

In xterm mode, there is no issue like above but non-ASCII text is displayed with black color, so it is hard to distinguish.

I think xterm mode is better, except #755 and this text color problem. Please allow to change color of non-ASCII words.

@Alex4386
Copy link

xterm issue is likely because of 3.13.0-beta1's issue.
try creating issue at the xterm.js.

build results of master branch (xterm == 3.13.0-beta1)
image

build results of modified version of master branch
(xterm version of terminus-terminal was modified to 3.12.2)
image

@hwooo
Copy link
Author

hwooo commented Apr 29, 2019

@Alex4386 How can I modify xterm version of Terminus?

@Eugeny
Copy link
Owner

Eugeny commented Apr 29, 2019

@NDelt you can't do it on a normal install - I'll release an update with a rolled back xterm version today

@Eugeny
Copy link
Owner

Eugeny commented Apr 29, 2019

Ref xtermjs/xterm.js#2031

@Eugeny
Copy link
Owner

Eugeny commented May 2, 2019

Fixed in xterm

@Eugeny Eugeny closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants