Don't print keys that print more than a single char

Fixes #1880
xtermjs · Jan 7, 2019 · 1964e52 · 1964e52
1 parent 740ca9c
commit 1964e52
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/core/input/Keyboard.ts b/src/core/input/Keyboard.ts
@@ -349,9 +349,8 @@ export function evaluateKeyboardEvent(
         if (ev.keyCode === 65) { // cmd + a
           result.type = KeyboardResultType.SELECT_ALL;
         }
-      } else if (ev.key && !ev.ctrlKey && !ev.altKey && !ev.metaKey &&
-          ev.keyCode >= 48 && ev.keyCode !== 144 && ev.keyCode !== 145) {
-        // Include only keys that that result in a character; don't include num lock and scroll lock
+      } else if (ev.key && !ev.ctrlKey && !ev.altKey && !ev.metaKey && ev.keyCode >= 48 && ev.key.length === 1) {
+        // Include only keys that that result in a _single_ character; don't include num lock, volume up, etc.
         result.key = ev.key;
       }
       break;