Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support form emulated<N> arch #1000

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add support form emulated<N> arch #1000

merged 1 commit into from
Mar 28, 2024

Conversation

serge-sans-paille
Copy link
Contributor

Fix #998

@serge-sans-paille serge-sans-paille changed the title Add support form emulated<N> arch [WIP] Add support form emulated<N> arch Jan 27, 2024
@serge-sans-paille serge-sans-paille force-pushed the feature/emulated branch 2 times, most recently from d0046e6 to 7c55b82 Compare January 29, 2024 20:29
@serge-sans-paille serge-sans-paille force-pushed the feature/emulated branch 2 times, most recently from f194632 to a6e0fed Compare March 24, 2024 07:10
@serge-sans-paille serge-sans-paille changed the title [WIP] Add support form emulated<N> arch Add support form emulated<N> arch Mar 24, 2024
@serge-sans-paille
Copy link
Contributor Author

@JohanMabille getting close to an end with this one, but I still need to double check if it works with Pythran as it touches xsimd_scalar.

@serge-sans-paille serge-sans-paille force-pushed the feature/emulated branch 8 times, most recently from 9409867 to 6b372a2 Compare March 24, 2024 11:44
@serge-sans-paille
Copy link
Contributor Author

Associated pythran build: serge-sans-paille/pythran#2188

@serge-sans-paille
Copy link
Contributor Author

pythran check ok, @JohanMabille I let you decide

JohanMabille
JohanMabille reviewed Mar 28, 2024
View reviewed changes
@serge-sans-paille
Add support form emulated<N> arch
86ceb6f 
As a side effect:

- provide a scalar version for xsimd::bitwise_cast.
- reorder some functions in xsimd_sse2.hpp

Fix #998
@serge-sans-paille
Copy link
Contributor Author

@JohanMabille all green even with the tests un-commented \o/

@JohanMabille JohanMabille merged commit f372568 into master Mar 28, 2024
118 checks passed
@JohanMabille JohanMabille deleted the feature/emulated branch March 28, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scalar implementation without code duplication
2 participants
@serge-sans-paille @JohanMabille